{{ message }}
[3.8] bpo-33418: Restore tp_clear for function object#16502
Merged
ambv merged 1 commit intoOct 1, 2019
Merged
Conversation
Member
Sorry, something went wrong.
This is a revert of the revert (pythonGH-15826). Having a tp_clear for functions should be safe (and helpful) now that bpo-38006 has been fixed.
tim-one
approved these changes
Oct 1, 2019
tim-one
left a comment
tim-one
left a comment
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Contributor
|
For reference:
|
Sorry, something went wrong.
|
@ambv: Please replace |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This is a revert of the revert (GH-15826, ccaea52). Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been fixed.
https://bugs.python.org/issue33418