{{ message }}
[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658)#16685
Merged
miss-islington merged 1 commit intoOct 9, 2019
Merged
Conversation
Member
Sorry, something went wrong.
pablogsal
changed the title
Member
Author
|
I'm fixing the errors from the merge conflicts |
Sorry, something went wrong.
tim-one
approved these changes
Oct 9, 2019
tim-one
left a comment
tim-one
left a comment
Member
There was a problem hiding this comment.
Perfect - thank you again 😃
Sorry, something went wrong.
…ythonGH-16658) * bpo-38379: when a finalizer resurrects an object, nothing is actually collected in this run of gc. Change the stats to relect that truth.. (cherry picked from commit ecbf35f) Co-authored-by: Tim Peters <tim.peters@gmail.com>
pablogsal
force-pushed
the
backport-ecbf35f-3.7
branch
from
62da4ca to
92fab65
Compare
October 9, 2019 21:24
Member
|
Looks like the |
Sorry, something went wrong.
Member
Author
Yeah, for some reason I did not push correctly my latest fixes for the merge conflicts. Apologies for the confusion! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
nothing is actually collected in this run of gc.
Change the stats to relect that truth..
(cherry picked from commit ecbf35f)
Co-authored-by: Tim Peters tim.peters@gmail.com
https://bugs.python.org/issue38379
Automerge-Triggered-By: @pablogsal