◐ Shell
reader mode source ↗
Skip to content

bpo-38449: Add URL delimiters test cases#16729

Merged
maxking merged 2 commits into
python:masterfrom
corona10:bpo-38449
Dec 1, 2019
Merged

bpo-38449: Add URL delimiters test cases#16729
maxking merged 2 commits into
python:masterfrom
corona10:bpo-38449

Conversation

@corona10

@corona10 corona10 commented Oct 12, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from a team as a code owner October 12, 2019 17:04
@corona10 corona10 requested a review from maxking October 12, 2019 17:07
maxking
maxking suggested changes Oct 12, 2019
View reviewed changes

@maxking maxking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I think semicolon is only one of the tricky case, there could be others which would result in a similar error case, especially the delimiters for various parts of a URL:

  scheme://netloc/path;parameters?query#fragment

So, I think, ;, ? and # would have similar behaviour when parsing using urllib.parse.urlparse for determining the mimetype.

@bedevere-bot

bedevere-bot commented Oct 12, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10

corona10 commented Oct 12, 2019

Copy link
Copy Markdown
Member Author

Thanks for the review.
I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Oct 12, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from maxking October 12, 2019 17:25
@corona10 corona10 changed the title bpo-38449: Add tricky test cases Oct 12, 2019
@corona10

corona10 commented Nov 10, 2019

Copy link
Copy Markdown
Member Author

@maxking gentle ping~

@maxking maxking merged commit 2fe4c48 into python:master Dec 1, 2019
@bedevere-bot

bedevere-bot commented Dec 1, 2019

Copy link
Copy Markdown

@maxking: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot

bedevere-bot commented Dec 1, 2019

Copy link
Copy Markdown

GH-17431 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@corona10 @miss-islington
bpo-38449: Add URL delimiters test cases (pythonGH-16729) …
a4f0e14 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@miss-islington

miss-islington commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@corona10 @miss-islington
bpo-38449: Add URL delimiters test cases (pythonGH-16729) …
141c184 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

bedevere-bot commented Dec 1, 2019

Copy link
Copy Markdown

GH-17432 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @corona10
bpo-38449: Add URL delimiters test cases (GH-16729) …
926eabb 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @corona10
bpo-38449: Add URL delimiters test cases (GH-16729) …
4f1eaf0 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10
bpo-38449: Add URL delimiters test cases (python#16729) …
16b6604 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
@corona10 corona10 deleted the bpo-38449 branch December 12, 2019 15:20
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
bpo-38449: Add URL delimiters test cases (python#16729) …
ce280a7 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxking maxking Awaiting requested review from maxking

Assignees

@maxking maxking

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @bedevere-bot @miss-islington @maxking @the-knights-who-say-ni