bpo-38652: Remove provisional note for asyncio.BufferedProtocol#17047
bpo-38652: Remove provisional note for asyncio.BufferedProtocol#17047miss-islington merged 3 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
Sorry, something went wrong.
aeros
left a comment
There was a problem hiding this comment.
Thanks for the PR @Anj-A, this looks exactly as I described in the issue, with removing the provisional note while retaining a versionadded note. I'll add a label to backport it to the 3.8 branch as well.
Sorry, something went wrong.
|
Also, if you could update the PR title to be more specifically descriptive of the changes made, that would be helpful. The actual changes made are correct though. The only thing remaining after that is for the CLA to be signed and processed, but that usually only takes around 24-48 hours. |
Sorry, something went wrong.
|
Have signed the CLA and updated the title as suggested. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Thanks @Anj-A for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
|
I'm having trouble backporting to |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
|
The fix should not be backported to 3.8, that's perfectly fine if 3.8 still states that BufferedProtocol is still provisional. |
Sorry, something went wrong.
Okay, I'll remove the backport label then. Does this also apply to other provisional APIs as well, as in they remain provisional for the major version they were released on? |
Sorry, something went wrong.
|
I doubt if we have a strong rule for the provisional status cleanup. |
Sorry, something went wrong.
https://bugs.python.org/issue38652
Automerge-Triggered-By: @asvetlov