◐ Shell
reader mode source ↗
Skip to content

closes bpo-38692: Add a pidfd child process watcher to asyncio.#17069

Merged
benjaminp merged 1 commit into
python:masterfrom
benjaminp:asyncio-pidfd
Nov 14, 2019
Merged

closes bpo-38692: Add a pidfd child process watcher to asyncio.#17069
benjaminp merged 1 commit into
python:masterfrom
benjaminp:asyncio-pidfd

Conversation

@benjaminp

@benjaminp benjaminp commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the PR @benjaminp. I have a few recommendations (mostly minor):

@benjaminp benjaminp merged commit 3ccdd9b into python:master Nov 14, 2019
@benjaminp benjaminp deleted the asyncio-pidfd branch November 14, 2019 03:08
@aeros

aeros commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

Thanks @benjaminp! Meant to approve this after the most recent commit, everything looks good to me.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants