◐ Shell
reader mode source ↗
Skip to content

bpo-38328: Speed up the creation time of constant list and set literals.#17114

Merged
methane merged 12 commits into
python:masterfrom
brandtbucher:compile-constant-collections
Nov 26, 2019
Merged

bpo-38328: Speed up the creation time of constant list and set literals.#17114
methane merged 12 commits into
python:masterfrom
brandtbucher:compile-constant-collections

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 12, 2019

Copy link
Copy Markdown
Member

At @methane's request, here is an alternate PR that takes place in the compiler, not the peephole optimizer. It would replace both #16498 and #16878.

I think I like this one better.

https://bugs.python.org/issue38328

@brandtbucher

Copy link
Copy Markdown
Member Author

@benjaminp, care to take a look at this when you have a chance?

@methane

methane commented Nov 25, 2019

Copy link
Copy Markdown
Member

Would you merge master and make regen-all?

@brandtbucher

Copy link
Copy Markdown
Member Author

Thanks @methane. This branch is no longer stale.

@methane methane merged commit 6dd9b64 into python:master Nov 26, 2019
@brandtbucher

Copy link
Copy Markdown
Member Author

Thanks for the guidance and merge @methane!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher brandtbucher deleted the compile-constant-collections branch July 21, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants