◐ Shell
reader mode source ↗
Skip to content

bpo-37838: get_type_hints for wrapped functions with forward reference#17126

Merged
ilevkivskyi merged 5 commits into
python:masterfrom
benedwards14:wrapped_check_type_def
Nov 21, 2019
Merged

bpo-37838: get_type_hints for wrapped functions with forward reference#17126
ilevkivskyi merged 5 commits into
python:masterfrom
benedwards14:wrapped_check_type_def

Conversation

@benedwards14

@benedwards14 benedwards14 commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

brandtbucher
brandtbucher requested changes Nov 12, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks like a good change to me! Just a few comments below to fix CI and clean things up.

@brandtbucher brandtbucher added the type-bug An unexpected behavior, bug, or error label Nov 12, 2019
@brandtbucher

brandtbucher commented Nov 12, 2019

Copy link
Copy Markdown
Member

Thanks for the PR @benedwards14!

This one should also have a NEWS entry. Just something simple, like:

:meth:`typing.get_type_hints` properly handles functions decorated with :meth:`functors.wraps`.

@benedwards14

benedwards14 commented Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hey @brandtbucher, thanks for the review. Here are the markups.

brandtbucher
brandtbucher requested changes Nov 21, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good! Just a couple of remaining style nitpicks:

brandtbucher
brandtbucher requested changes Nov 21, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Sorry, one last typo I spotted. Then good!

@benedwards14 @brandtbucher
Update Misc/NEWS.d/next/Library/2019-11-21-11-39-17.bpo-37838.lRFcEC.rst …
f7815a2 
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@brandtbucher

brandtbucher commented Nov 21, 2019

Copy link
Copy Markdown
Member

@ilevkivskyi

ilevkivskyi
ilevkivskyi approved these changes Nov 21, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good, thanks!

@ilevkivskyi

ilevkivskyi commented Nov 21, 2019

Copy link
Copy Markdown
Member

(Added backport labels since this is a bugfix.)

@ilevkivskyi ilevkivskyi merged commit 0aca3a3 into python:master Nov 21, 2019
@miss-islington

miss-islington commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @benedwards14 for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 21, 2019

Copy link
Copy Markdown

GH-17324 is a backport of this pull request to the 3.8 branch.

@sthagen sthagen mentioned this pull request Nov 21, 2019
Merged
@bedevere-bot

bedevere-bot commented Nov 21, 2019

Copy link
Copy Markdown

GH-17325 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@benedwards14 @miss-islington
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
324ba4b 
pythonGH-17126)

https://bugs.python.org/issue37838
(cherry picked from commit 0aca3a3)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@benedwards14 @miss-islington
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
20a0c7e 
pythonGH-17126)

https://bugs.python.org/issue37838
(cherry picked from commit 0aca3a3)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @benedwards14
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
30e5bd8 
GH-17126)

https://bugs.python.org/issue37838
(cherry picked from commit 0aca3a3)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @benedwards14
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
9458c5c 
GH-17126)

https://bugs.python.org/issue37838
(cherry picked from commit 0aca3a3)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@benedwards14
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
d582608 
pythonGH-17126)

https://bugs.python.org/issue37838
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@benedwards14 @shihai1991
bpo-37838: get_type_hints for wrapped functions with forward reference ( …
6d41fe9 
pythonGH-17126)

https://bugs.python.org/issue37838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benedwards14 @brandtbucher @ilevkivskyi @miss-islington @bedevere-bot @the-knights-who-say-ni