◐ Shell
reader mode source ↗
Skip to content

bpo-16500: Allow registering at-fork handlers#1715

Merged
pitrou merged 6 commits into
python:masterfrom
pitrou:at_fork
May 27, 2017
Merged

bpo-16500: Allow registering at-fork handlers#1715
pitrou merged 6 commits into
python:masterfrom
pitrou:at_fork

Conversation

@pitrou

@pitrou pitrou commented May 22, 2017

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

mention-bot commented May 22, 2017

Copy link
Copy Markdown

@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @rhettinger and @tim-one to be potential reviewers.

@pitrou pitrou added the type-feature A feature request or enhancement label May 22, 2017
@1st1 1st1 self-requested a review May 22, 2017 18:40
@pitrou

pitrou commented May 26, 2017

Copy link
Copy Markdown
Member Author

@1st1, were you planning to review this?

@1st1

1st1 commented May 26, 2017

Copy link
Copy Markdown
Member

@1st1, were you planning to review this?

Yes, LGTM from me. I'm going to use this API in uvloop (now I use pthread_atfork) and I wanted to make sure that my use case is covered. And it is! Thanks for working on this.

@1st1

1st1 commented May 26, 2017

Copy link
Copy Markdown
Member

My only question (that shouldn't block this PR from being merged) is can we use pthread_atfork in CPython? That would make this API work even when a C extension is calling fork directly, bypassing the CPython API.

@gpshead

gpshead commented May 26, 2017 via email

Copy link
Copy Markdown
Member

@1st1

1st1 commented May 26, 2017

Copy link
Copy Markdown
Member

Thanks, Gregory, it makes sense.

@pitrou pitrou merged commit 346cbd3 into python:master May 27, 2017
@pitrou pitrou deleted the at_fork branch May 27, 2017 15:50
ma8ma added a commit to ma8ma/cpython that referenced this pull request Jun 13, 2017
@ma8ma
Merge commit 'master' into pep539-tss-api …
08f1fa8 
Resolve conflicts:
346cbd3 bpo-16500: Allow registering at-fork handlers (python#1715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@1st1 1st1

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pitrou @mention-bot @1st1 @gpshead @serhiy-storchaka @the-knights-who-say-ni