◐ Shell
reader mode source ↗
Skip to content

bpo-38823: Clean up refleaks in _contextvars initialization.#17198

Merged
miss-islington merged 1 commit into
python:masterfrom
brandtbucher:_contextvars
Nov 16, 2019
Merged

bpo-38823: Clean up refleaks in _contextvars initialization.#17198
miss-islington merged 1 commit into
python:masterfrom
brandtbucher:_contextvars

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 16, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher requested a review from 1st1 as a code owner November 16, 2019 23:13
@brandtbucher brandtbucher added skip news type-bug An unexpected behavior, bug, or error labels Nov 16, 2019
@miss-islington

miss-islington commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 143a97f into python:master Nov 16, 2019
@miss-islington

miss-islington commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington

miss-islington commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@asvetlov

asvetlov commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Thanks again!

@bedevere-bot

bedevere-bot commented Nov 16, 2019

Copy link
Copy Markdown

GH-17199 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2019
@brandtbucher @miss-islington
bpo-38823: Clean up refleaks in _contextvars initialization. (pythonG… …
398711f 
…H-17198)

https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@miss-islington

miss-islington commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 16, 2019

Copy link
Copy Markdown

GH-17200 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 17, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _contextvars initialization. (GH-17198) …
8a334af 
https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
miss-islington added a commit that referenced this pull request Nov 17, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _contextvars initialization. (GH-17198) …
1fe79a4 
https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brandtbucher
bpo-38823: Clean up refleaks in _contextvars initialization. (pythonG… …
937d017 
…H-17198)

https://bugs.python.org/issue38823
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher @shihai1991
bpo-38823: Clean up refleaks in _contextvars initialization. (pythonG… …
3f1c164 
…H-17198)

https://bugs.python.org/issue38823
@brandtbucher brandtbucher deleted the _contextvars branch July 21, 2022 20:00
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brandtbucher @miss-islington @asvetlov @bedevere-bot @the-knights-who-say-ni