◐ Shell
reader mode source ↗
Skip to content

bpo-32604: Expose the subinterpreters C-API in a "private" stdlib module.#1748

Merged
ericsnowcurrently merged 78 commits into
python:masterfrom
ericsnowcurrently:low-level-interpreters-module
Jan 30, 2018
Merged

bpo-32604: Expose the subinterpreters C-API in a "private" stdlib module.#1748
ericsnowcurrently merged 78 commits into
python:masterfrom
ericsnowcurrently:low-level-interpreters-module

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from e0611a8 to bee1baa Compare May 23, 2017 04:38
@ericsnowcurrently ericsnowcurrently changed the title Expose the subinterpreters C-API in a "private" stdlib module. May 23, 2017
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from bee1baa to 060a720 Compare May 23, 2017 23:42
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 24, 2017
Closed
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 060a720 to 2fd0e64 Compare August 22, 2017 20:01
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 2 times, most recently from 114bda4 to 52ca360 Compare September 7, 2017 17:58
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 52ca360 to 9991d75 Compare November 27, 2017 23:24
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 9991d75 to e9d9b04 Compare December 5, 2017 01:29
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 81de3c8 to bfc025f Compare December 12, 2017 05:12
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 2 times, most recently from e05d02e to 396e294 Compare December 23, 2017 00:30
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 3 times, most recently from 5266080 to c86647a Compare January 13, 2018 00:49
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 2 times, most recently from ff4ae72 to 0981dbf Compare January 20, 2018 01:44
@ericsnowcurrently ericsnowcurrently changed the title bpo-30439: Expose the subinterpreters C-API in a "private" stdlib module. Jan 20, 2018
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 0981dbf to 0be6314 Compare January 20, 2018 02:13
102 hidden items Load more…
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 8ae8507 to 2ebc68c Compare January 27, 2018 19:15
@ericsnowcurrently

ericsnowcurrently commented Jan 27, 2018

Copy link
Copy Markdown
Member Author

FYI, I've temporarily removed the Windows support to see if anything else breaks. I'll add it back in soon. I do not plan on merging this without it.

@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 2 times, most recently from ebbf591 to 9718b91 Compare January 27, 2018 21:07
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch 2 times, most recently from edec009 to 092fccc Compare January 27, 2018 22:50
@ericsnowcurrently ericsnowcurrently force-pushed the low-level-interpreters-module branch from 092fccc to b07e928 Compare January 27, 2018 23:19
@ericsnowcurrently

ericsnowcurrently commented Jan 27, 2018

Copy link
Copy Markdown
Member Author

@zooba I suspect my problem is with Py_BUILD_CORE. When I don't set it I don't get the symbols out of Include/internal. When I do set it I end up missing stuff from python37.lib at link time. I tried adding a "Link" directive right below where I set Py_BUILD_CORE, but that did not help. :/ Any ideas on what I need to do?

@ericsnowcurrently

ericsnowcurrently commented Jan 29, 2018

Copy link
Copy Markdown
Member Author

@python/windows-team Any of you have ideas on how I can get this PR to link on Windows?

@ericsnowcurrently

ericsnowcurrently commented Jan 30, 2018

Copy link
Copy Markdown
Member Author

In the interest of the feature freeze I'm going to land the PR without Windows support. :/ The risk for beta1 is low since the PR does not have any OS-specific code and the new module is only for use in the test suite. I'll work on getting Windows support done ASAP.

@ericsnowcurrently ericsnowcurrently merged commit 7f8bfc9 into python:master Jan 30, 2018
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jan 30, 2018
Closed
@ericsnowcurrently ericsnowcurrently deleted the low-level-interpreters-module branch February 3, 2018 04:54
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments

@ncoghlan ncoghlan ncoghlan left review comments

@pitrou pitrou pitrou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ericsnowcurrently @1st1 @zooba @ncoghlan @pitrou @Mariatta @the-knights-who-say-ni