{{ message }}
[3.7] bpo-38547: Fix test_pty if the process is the session leader (GH-17519)#17521
Merged
miss-islington merged 1 commit intoDec 9, 2019
Merged
Conversation
Contributor
Sorry, something went wrong.
vstinner
approved these changes
Dec 9, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM, good bot.
Sorry, something went wrong.
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fix test_pty: if the process is the session leader, closing the
master file descriptor raises a SIGHUP signal: simply ignore SIGHUP
when running the tests.
(cherry picked from commit a1838ec)
Co-authored-by: Victor Stinner vstinner@python.org
https://bugs.python.org/issue38547