◐ Shell
reader mode source ↗
Skip to content

bpo-28754: AC on bisect.#177

Closed
JulienPalard wants to merge 1 commit into
python:masterfrom
JulienPalard:issue28754-ac-bisect
Closed

bpo-28754: AC on bisect.#177
JulienPalard wants to merge 1 commit into
python:masterfrom
JulienPalard:issue28754-ac-bisect

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Feb 19, 2017 •
edited by methane
Loading

Copy link
Copy Markdown
Member

@JulienPalard JulienPalard changed the title bpo28754: AC on bisect. Feb 19, 2017
methane
methane reviewed Feb 20, 2017
View reviewed changes

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.
But please wait approval from expert.
(@rhettinger is listed on http://cpython-devguide.readthedocs.io/experts.html)

@rhettinger rhettinger self-assigned this Apr 5, 2017
@rhettinger

rhettinger commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

I don't want the pure python API to change at all. It is a long standing API and there is nothing wrong with it. Also, passing it -1 here as a special value makes real code less readable. Further, the change slightly slows down the case where high is specified. In a high performance building block module, we shouldn't add in unnecessary checks.

@brettcannon

brettcannon commented Feb 21, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

akruis added a commit to akruis/cpython that referenced this pull request Nov 1, 2018
@akruis
Stackless issue python#177: Fix prickelpit.c function slp_cannot_exec… …
5a574b8 
…ute()

I missed the C-fame case, when I changed the frame-function ref counting
in Stackless issue python#117.
@JulienPalard JulienPalard deleted the issue28754-ac-bisect branch June 16, 2019 14:05
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 3.10.1 to 4.0.0 (#177)
5a43e6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@rhettinger rhettinger

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulienPalard @rhettinger @brettcannon @methane @serhiy-storchaka @the-knights-who-say-ni