{{ message }}
[3.5] bpo-29334: Fix ssl.getpeercert for auto-handshake (GH-1769)#1779
Closed
tiran wants to merge 1 commit into
Closed
[3.5] bpo-29334: Fix ssl.getpeercert for auto-handshake (GH-1769)#1779tiran wants to merge 1 commit into
tiran wants to merge 1 commit into
Conversation
Member
Sorry, something went wrong.
Drop handshake_done and peer_cert members from PySSLSocket struct. The peer certificate can be acquired from *SSL directly. SSL_get_peer_certificate() does not trigger any network activity. Instead of manually tracking the handshake state, simply use SSL_is_init_finished(). In combination these changes fix auto-handshake for non-blocking MemoryBIO connections. Signed-off-by: Christian Heimes <christian@python.org>. (cherry picked from commit 66dc33b)
Member
|
Is this ready to merge? |
Sorry, something went wrong.
Contributor
|
Just a reminder: I expect to tag 3.5.4rc1 in eleven or twelve hours. If this is a bugfix (not a security fix), and it isn't merged by then, it will probably never be merged into 3.5. |
Sorry, something went wrong.
Member
Author
|
It's a bug fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Drop handshake_done and peer_cert members from PySSLSocket struct. The
peer certificate can be acquired from *SSL directly.
SSL_get_peer_certificate() does not trigger any network activity.
Instead of manually tracking the handshake state, simply use
SSL_is_init_finished().
In combination these changes fix auto-handshake for non-blocking
MemoryBIO connections.
Signed-off-by: Christian Heimes christian@python.org.
(cherry picked from commit 66dc33b)