{{ message }}
Py_DECREF: only pass filename if Py_REF_DEBUG is defined#17870
Merged
vstinner merged 2 commits intoJan 8, 2020
Merged
Conversation
Member
Sorry, something went wrong.
Filename and line numbers are not needed when Py_REF_DEBUG are not defined. The static inline _Py_DECREF() function was introduced by commit 2aaf0c1.
Member
Author
|
@Yhg1s @serhiy-storchaka: Does this version look better than PR #16781? |
Sorry, something went wrong.
Yhg1s
approved these changes
Jan 8, 2020
Yhg1s
left a comment
Yhg1s
left a comment
Member
There was a problem hiding this comment.
Yes, this looks better to me. The ifdef dance isn't too bad, and it's no longer duplicating logic.
Sorry, something went wrong.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
) Filename and line numbers are not needed when Py_REF_DEBUG are not defined. The static inline _Py_DECREF() function was introduced by commit 2aaf0c1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Filename and line numbers are not needed when Py_REF_DEBUG are not
defined.
The static inline _Py_DECREF() function was introduced by
commit 2aaf0c1.