◐ Shell
reader mode source ↗
Skip to content

bpo-12159: document sys.maxsize limit in len() function reference#17934

Merged
vstinner merged 1 commit into
python:masterfrom
Zac-HD:document-len-overflow
Jan 12, 2020
Merged

bpo-12159: document sys.maxsize limit in len() function reference#17934
vstinner merged 1 commit into
python:masterfrom
Zac-HD:document-len-overflow

Conversation

@Zac-HD

@Zac-HD Zac-HD commented Jan 10, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

See:

  • BPO-12159: "needs to be documented",
  • BPO-15718: added note to datamodel docs for __len__ method but not len(), and
  • BPO-21444: change request / wontfix

https://bugs.python.org/issue12159

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 10, 2020
@cool-RR

cool-RR commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

I think that this is a good addition to the documentation, but the example with range is weird. Maybe you mean that big ranges, such as range(10 ** 100) will be too big. That isn't clear from your text.

@vstinner vstinner changed the title BPO-12159: document sys.maxsize limit in function reference for len() Jan 11, 2020
vstinner
vstinner approved these changes Jan 11, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, but I would prefer to get a second review. @csabella @serhiy-storchaka @JulienPalard: What do you think of this len note?

csabella
csabella approved these changes Jan 12, 2020
View reviewed changes

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Since this has been brought up multiple times, I think it's best to document it, especially since __len__ had a note added in the past. Thanks for the patch, @Zac-HD!

@bedevere-bot

bedevere-bot commented Jan 12, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Zac-HD

Zac-HD commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 12, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@csabella, @vstinner: please review the changes made to this pull request.

@vstinner vstinner merged commit d7c7add into python:master Jan 12, 2020
@Zac-HD Zac-HD deleted the document-len-overflow branch January 12, 2020 10:33
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Zac-HD @shihai1991
bpo-12159: Document sys.maxsize limit in len() function reference (py… …
a8074ea 
…thonGH-17934)
@Zac-HD Zac-HD mentioned this pull request Mar 28, 2020
Draft
4 tasks
@cool-RR cool-RR mannequin mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella Awaiting requested review from csabella

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zac-HD @cool-RR @bedevere-bot @vstinner @csabella @the-knights-who-say-ni