bpo-39290: Add support for import_as_names for traverse_imports#17944
bpo-39290: Add support for import_as_names for traverse_imports#17944isidentical wants to merge 1 commit into
Conversation
2259126 to
1088b0f
Compare
January 11, 2020 21:32
|
Could you also add a test for this? (Note: the suggested reviewers were autoselected by the |
Sorry, something went wrong.
brettcannon
left a comment
There was a problem hiding this comment.
Please add tests.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
This is a nice to have feature for outside usages but unfortunately, the current test suite doesn't offer a direct way to test it with the given interface of fixers. Also, I am now reconsidering if this suits the concept of lib2to3 fixers and their public utilities. @benjaminp what do you think about supporting these symbols in the fixer for outside usages (e.g: packages like unimport) ? |
Sorry, something went wrong.
|
[closing as this was an nice-to-have enhancement, and lib2to3 will be deprecated soon and this will probably not going to be in time for 3.9] |
Sorry, something went wrong.
https://bugs.python.org/issue39290