◐ Shell
reader mode source ↗
Skip to content

bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module#18011

Merged
miss-islington merged 2 commits into
python:masterfrom
chrisburr:fix-issue-39342
Mar 18, 2021
Merged

bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module#18011
miss-islington merged 2 commits into
python:masterfrom
chrisburr:fix-issue-39342

Conversation

@chrisburr

@chrisburr chrisburr commented Jan 15, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Exposes the X509_V_FLAG_ALLOW_PROXY_CERTS constant as ssl.VERIFY_ALLOW_PROXY_CERTS to allow for proxy certificate validation as described in: https://www.openssl.org/docs/man1.1.1/man7/proxy-certificates.html

https://bugs.python.org/issue39342

Automerge-Triggered-By: GH:tiran

@chrisburr chrisburr requested a review from tiran as a code owner January 15, 2020 10:18
@tiran

tiran commented Jan 15, 2020

Copy link
Copy Markdown
Member

Thanks, your patch looks good to me.

I cannot approve the PR at the moment. GH request fails with Personal token required for this feature. I'll look into the matter later.

@chrisburr

chrisburr commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

@tiran Sorry to pester you, but could you take a look when you get a chance?

I'm fairly sure Travis CI failed due to a network glitch.

@chaen

chaen commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

I too would like to see this PR be merged. Is there anything I can do to help ?

20 hidden items Load more…
@terryjreedy

terryjreedy commented Dec 9, 2020

Copy link
Copy Markdown
Member

The bogus review requests and CLA report are likely a result of force-pushing. This should not be be used when git merge origin/master is all that is needed.

@brettcannon brettcannon removed their request for review December 9, 2020 17:37
@chrisburr

chrisburr commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

I accidentally rebased on my fork's master instead of python/cpython which seems to have triggered GitHub to automatically request a review from many people. Sorry for the trouble.

@vsajip vsajip removed their request for review December 14, 2020 10:19
@methane methane removed their request for review March 18, 2021 07:17
@miss-islington miss-islington merged commit e0b4aa0 into python:master Mar 18, 2021
@chrisburr chrisburr deleted the fix-issue-39342 branch March 18, 2021 09:15
jab added a commit to jab/cpython that referenced this pull request Mar 20, 2021
@jab
Merge branch 'master' into justin39/aiter-c …
97d06e5 
* master: (129 commits)
  bpo-43452: Micro-optimizations to PyType_Lookup (pythonGH-24804)
  bpo-43517: Fix false positive in detection of circular imports (python#24895)
  bpo-43494: Make some minor changes to lnotab notes (pythonGH-24861)
  Mention that code.co_lnotab is deprecated in what's new for 3.10. (python#24902)
  bpo-43244: Remove symtable.h header file (pythonGH-24910)
  bpo-43466: Add --with-openssl-rpath configure option (pythonGH-24820)
  Fix a typo in c-analyzer (pythonGH-24468)
  bpo-41561: Add workaround for Ubuntu's custom security level (pythonGH-24915)
  bpo-43521: Allow ast.unparse with empty sets and NaN (pythonGH-24897)
  bpo-43244: Remove the PyAST_Validate() function (pythonGH-24911)
  bpo-43541: Fix PyEval_EvalCodeEx() regression (pythonGH-24918)
  bpo-43244: Fix test_peg_generators on Windows (pythonGH-24913)
  bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module (pythonGH-18011)
  bpo-43244: Fix test_peg_generator for PyAST_Validate() (pythonGH-24912)
  bpo-42128: Add 'missing :' syntax error message to match statements (pythonGH-24733)
  bpo-43244: Add pycore_ast.h header file (pythonGH-24908)
  bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (pythonGH-24907)
  Remove unnecessary imports in the grammar parser (pythonGH-24904)
  bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pythonGH-24843)
  Add PEP 626 to what's new in 3.10. (python#24892)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@1st1 1st1

@abalkin abalkin Awaiting requested review from abalkin

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@gpshead gpshead Awaiting requested review from gpshead

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@pganssle pganssle Awaiting requested review from pganssle

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chrisburr @tiran @chaen @the-knights-who-say-ni @terryjreedy @bedevere-bot @miss-islington