◐ Shell
reader mode source ↗
Skip to content

Ignore NEWS snippets in code coverage stats#18194

Merged
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:ignore-misc-subdirs-in-codecov
Jan 27, 2020
Merged

Ignore NEWS snippets in code coverage stats#18194
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:ignore-misc-subdirs-in-codecov

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jan 26, 2020

Copy link
Copy Markdown
Contributor

In trying to work out what was wrong with the code coverage stats on #18066,
I realised we weren't ignoring the Misc/NEWS.d subdirectory correctly.

@ncoghlan ncoghlan mentioned this pull request Jan 26, 2020
Closed
shihai1991
shihai1991 approved these changes Jan 26, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thanks.

@ncoghlan ncoghlan merged commit 7023288 into python:master Jan 27, 2020
@ncoghlan ncoghlan deleted the ignore-misc-subdirs-in-codecov branch January 27, 2020 16:05
@vstinner

vstinner commented Jan 27, 2020

Copy link
Copy Markdown
Member

If coverage tests are run on other branches, you may want to backport your change to 3.7 and 3.8.

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Sorry @ncoghlan, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7023288dc500008609e7a4d12ae710c2093c3fc6 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@ncoghlan @miss-islington
Ignore NEWS snippets in code coverage stats (pythonGH-18194) …
4972a94 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 27, 2020

Copy link
Copy Markdown

GH-18200 is a backport of this pull request to the 3.7 branch.

@ncoghlan

ncoghlan commented Jan 27, 2020

Copy link
Copy Markdown
Contributor Author

Good point!

@miss-islington

miss-islington commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@ncoghlan @miss-islington
Ignore NEWS snippets in code coverage stats (pythonGH-18194) …
eed50cc 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 27, 2020

Copy link
Copy Markdown

GH-18201 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @ncoghlan
Ignore NEWS snippets in code coverage stats (GH-18194) …
414ab5d 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @ncoghlan
Ignore NEWS snippets in code coverage stats (GH-18194) …
57e7e57 
(cherry picked from commit 7023288)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ncoghlan @shihai1991
Ignore NEWS snippets in code coverage stats (pythonGH-18194)
e2fe931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees

@ncoghlan ncoghlan

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ncoghlan @vstinner @miss-islington @bedevere-bot @methane @shihai1991 @the-knights-who-say-ni