gh-58319: IDLE: Add interrupt handle when open debugger#1821
Conversation
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers. |
Sorry, something went wrong.
auvipy
left a comment
There was a problem hiding this comment.
rebase needed
Sorry, something went wrong.
|
I'm wondering about the naming of the function "user_interrupt". The other "user_*" functions ("user_line", "user_exception", etc.) are Bdb callbacks that allow the debugger to update itself based on the current state of the running program. In this case, we're actually trying to control the running program, and this routine is called by our own code, not Bdb. The Bdb "set_" functions do control the running program, so we could consider "set_interrupt". The only potential downside is that it wouldn't be clear that this isn't a Bdb function. Perhaps something along the lines of "force_interrupt"? I'm not normally super-pendantic about names, but with all the difference places where code is running in the debugger, it's hard enough to follow as it is, so anything that can be done in IDLE to avoid confusion is a good thing. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
iritkatriel
left a comment
There was a problem hiding this comment.
This has merge conflicts now.
Sorry, something went wrong.
|
As with #15027, the merge conflict in run.py is because part of This PR also needs new tests. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Patch by: Roger Serwy
https://bugs.python.org/issue14111