◐ Shell
reader mode source ↗
Skip to content

bpo-39128: Added happy_eyeballs_delay, interleave to function signature#18315

Merged
JulienPalard merged 2 commits into
python:masterfrom
idomic:39128-Document_happy_eyeball
Feb 10, 2020
Merged

bpo-39128: Added happy_eyeballs_delay, interleave to function signature#18315
JulienPalard merged 2 commits into
python:masterfrom
idomic:39128-Document_happy_eyeball

Conversation

@idomic

@idomic idomic commented Feb 2, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@idomic idomic requested review from 1st1 and asvetlov as code owners February 2, 2020 15:08
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 2, 2020
@idomic

idomic commented Feb 2, 2020

Copy link
Copy Markdown
Contributor Author

@asvetlov Do I need news here? it's only documentation.
Would you also like to include a paragraph on the algorithm after the changeset, Changed in version 3.5: Added support for SSL/TLS in ProactorEventLoop. ?

@JulienPalard JulienPalard changed the title 39128 - Added happy_eyeballs_delay, interleave to function signature Feb 6, 2020
@JulienPalard

JulienPalard commented Feb 6, 2020

Copy link
Copy Markdown
Member

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

@idomic

idomic commented Feb 8, 2020

Copy link
Copy Markdown
Contributor Author

.. versionchanged:: 3.8
Added the happy_eyeballs_delay and interleave parameters.

I agree

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

Done.

@JulienPalard JulienPalard merged commit 5305cc9 into python:master Feb 10, 2020
@miss-islington

miss-islington commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @idomic for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 10, 2020

Copy link
Copy Markdown

GH-18428 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@idomic @miss-islington
bpo-39128: Added happy_eyeballs_delay, interleave to function signatu… …
702f0f0 
…re (pythonGH-18315)

(cherry picked from commit 5305cc9)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Feb 10, 2020
@miss-islington @idomic
bpo-39128: Added happy_eyeballs_delay, interleave to function signatu… …
af95d79 
…re (GH-18315)

(cherry picked from commit 5305cc9)

Co-authored-by: idomic <michael.ido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@idomic @JulienPalard @miss-islington @bedevere-bot @the-knights-who-say-ni