◐ Shell
reader mode source ↗
Skip to content

[3.8] bpo-37224: Improve test__xxsubinterpreters.DestroyTests (GH-18058)#18318

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-f03a8f8-3.8
Feb 4, 2020
Merged

[3.8] bpo-37224: Improve test__xxsubinterpreters.DestroyTests (GH-18058)#18318
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-f03a8f8-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds an additional assertion check based on a race condition for test__xxsubinterpreters.DestroyTests.test_still_running discovered in the bpo issue.

https://bugs.python.org/issue37224
(cherry picked from commit f03a8f8)

Co-authored-by: Kyle Stanley aeros167@gmail.com

https://bugs.python.org/issue37224

Automerge-Triggered-By: @ericsnowcurrently

@aeros @miss-islington
bpo-37224: Improve test__xxsubinterpreters.DestroyTests (pythonGH-18058) …
e805fac 
Adds an additional assertion check based on a race condition for `test__xxsubinterpreters.DestroyTests.test_still_running` discovered in the bpo issue.

https://bugs.python.org/issue37224
(cherry picked from commit f03a8f8)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Feb 3, 2020
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels Feb 3, 2020
@miss-islington

miss-islington commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

@aeros: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington

miss-islington commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

@aeros: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

@aeros: Status check is done, and it's a success ✅ .

ericsnowcurrently
ericsnowcurrently approved these changes Feb 4, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@miss-islington miss-islington merged commit 9a740b6 into python:3.8 Feb 4, 2020
@miss-islington miss-islington deleted the backport-f03a8f8-3.8 branch February 4, 2020 15:31
@miss-islington

miss-islington commented Feb 4, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

1 similar comment
@miss-islington

miss-islington commented Feb 4, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@aeros

aeros commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

(I believe the above message occurred because miss-islington auto-merges backports when they're approved, so when the automerge label was added after approval there was nothing left to do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @aeros @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot