◐ Shell
reader mode source ↗
Skip to content

bpo-1635741: Fix refleaks of timemoudle in PyInit_time()#18486

Merged
vstinner merged 2 commits into
python:masterfrom
shihai1991:bpo_1635741_14
Mar 11, 2020
Merged

bpo-1635741: Fix refleaks of timemoudle in PyInit_time()#18486
vstinner merged 2 commits into
python:masterfrom
shihai1991:bpo_1635741_14

Conversation

@shihai1991

@shihai1991 shihai1991 commented Feb 12, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@shihai1991

shihai1991 commented Feb 12, 2020

Copy link
Copy Markdown
Member Author

cc @brandtbucher
Due to brandt have doing some refactoring work of PyModule_AddObject() ;)

brandtbucher
brandtbucher requested changes Feb 12, 2020
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for your work on this! Looks good, just one question below:

@brandtbucher brandtbucher added the type-bug An unexpected behavior, bug, or error label Feb 12, 2020
@vstinner vstinner merged commit 196f1eb into python:master Mar 11, 2020
@vstinner

vstinner commented Mar 11, 2020

Copy link
Copy Markdown
Member

Thanks @shihai1991, I merged your PR.

farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#18486: MINGW: dynamic loading support
b8d8a28
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@pganssle pganssle pganssle left review comments

@brandtbucher brandtbucher brandtbucher requested changes

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991 @vstinner @pganssle @brandtbucher @the-knights-who-say-ni @bedevere-bot