◐ Shell
reader mode source ↗
Skip to content

bpo-39573: Add Py_IS_TYPE macro#18488

Merged
vstinner merged 4 commits into
python:masterfrom
corona10:bpo-39573
Feb 13, 2020
Merged

bpo-39573: Add Py_IS_TYPE macro#18488
vstinner merged 4 commits into
python:masterfrom
corona10:bpo-39573

Conversation

@corona10

@corona10 corona10 commented Feb 12, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner
vstinner reviewed Feb 12, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I suggest to modify Argument Clinic in a separated PR, but use this PR to update PyXXX_CheckExact() macros. See: nascheme@c156300

You should credit Neil if you reuse his commit: add Author: Neil Schemenauer <nas-github@arctrix.com> at the end of your commit message.

@codecov

codecov Bot commented Feb 12, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #18488 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18488       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589145   414668   -174477     
  Branches    44447    44450        +3     
===========================================
- Hits       483801   345002   -138799     
+ Misses      95697    60016    -35681     
- Partials     9647     9650        +3
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac7ed...e49cc89. Read the comment docs.

@corona10 corona10 changed the title bpo-39573: Add Py_IS_TYPE macro Feb 12, 2020
@corona10
bpo-39573: Update PyXXX_CheckExact() APIs …
b31905e 
Co-Author: Neil Schemenauer <nas-github@arctrix.com>
@corona10 corona10 changed the title [WIP] bpo-39573: Add Py_IS_TYPE macro Feb 12, 2020
@corona10 corona10 requested a review from vstinner February 12, 2020 18:33
corona10
corona10 commented Feb 12, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@vstinner I've updated the PR :)

@corona10

corona10 commented Feb 13, 2020

Copy link
Copy Markdown
Member Author

@vstinner Updated! Thanks for the review

@corona10 corona10 requested a review from vstinner February 13, 2020 01:33
@corona10 corona10 requested a review from vstinner February 13, 2020 14:32
@corona10

corona10 commented Feb 13, 2020

Copy link
Copy Markdown
Member Author

@vstinner Updated :)

@vstinner vstinner merged commit d905df7 into python:master Feb 13, 2020
@vstinner

vstinner commented Feb 13, 2020

Copy link
Copy Markdown
Member

Thanks, merged. You can now redo your Argument Clinic change on top of it.

@vstinner vstinner mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot