◐ Shell
reader mode source ↗
Skip to content

bpo-30502: Fix handling of long oids#1852

Closed
tiran wants to merge 1 commit into
python:masterfrom
tiran:longoid
Closed

bpo-30502: Fix handling of long oids#1852
tiran wants to merge 1 commit into
python:masterfrom
tiran:longoid

Conversation

@tiran

@tiran tiran commented May 29, 2017

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes christian@python.org

@mention-bot

Copy link
Copy Markdown

@tiran, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @benjaminp, @malemburg and @tiran to be potential reviewers.

@tiran

tiran commented May 29, 2017

Copy link
Copy Markdown
Member Author

Signed-off-by: Christian Heimes <christian@python.org>

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, but I suggest the patch that don't duplicate the code (see on the tracker).

@serhiy-storchaka

Copy link
Copy Markdown
Member

An alternate patch is provided as #2909.

@tiran

tiran commented Sep 4, 2017

Copy link
Copy Markdown
Member Author

Closing in favor of #2909.

@tiran tiran closed this Sep 4, 2017
@tiran tiran deleted the longoid branch September 4, 2017 22:27
@Mariatta Mariatta removed labels Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants