◐ Shell
reader mode source ↗
Skip to content

bpo-39573: Clean up modules and headers to use Py_IS_TYPE#18521

Merged
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-39573-clean
Feb 17, 2020
Merged

bpo-39573: Clean up modules and headers to use Py_IS_TYPE#18521
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-39573-clean

Conversation

@corona10

@corona10 corona10 commented Feb 16, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from vstinner February 16, 2020 17:30
vstinner
vstinner requested changes Feb 17, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please don't use git rebase, just add a commit, to ease review ;-) This PR is long to review.

@bedevere-bot

bedevere-bot commented Feb 17, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner approved these changes Feb 17, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@bedevere-bot bedevere-bot added awaiting merge and removed labels Feb 17, 2020
@vstinner vstinner merged commit 1b55b65 into python:master Feb 17, 2020
@vstinner vstinner mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @bedevere-bot @vstinner @the-knights-who-say-ni