◐ Shell
reader mode source ↗
Skip to content

bpo-39674: Suggest to test with DeprecationWarning#18552

Merged
vstinner merged 4 commits into
python:masterfrom
vstinner:warn
Mar 3, 2020
Merged

bpo-39674: Suggest to test with DeprecationWarning#18552
vstinner merged 4 commits into
python:masterfrom
vstinner:warn

Conversation

@vstinner

@vstinner vstinner commented Feb 18, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add a section in What's New In Python 3.9 to strongly advice to check
for DeprecationWarning in your Python projects.

https://bugs.python.org/issue39674

@vstinner
bpo-39674: Suggest to test with DeprecationWarning …
7407e43 
Add a section in What's New In Python 3.9 to strongly advice to check
for DeprecationWarning in your Python projects.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Feb 18, 2020
@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
Member Author

@brettcannon: Does it sound like what you proposed in the python-dev thread?

hugovk
hugovk reviewed Feb 19, 2020
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Some minor spelling/language suggestions.

@brettcannon

brettcannon commented Feb 28, 2020

Copy link
Copy Markdown
Member

Yep, this is what I was thinking, but you forgot to mention -X dev 😉 .

@vstinner

vstinner commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

Yep, this is what I was thinking, but you forgot to mention -X dev wink .

Right. But you wrote that you wasn't convinced that the relationship between DeprecationWarning and -X dev, so I focused on warnings instead ;-)

@brettcannon

brettcannon commented Mar 3, 2020

Copy link
Copy Markdown
Member

I think it's also worth mentioning -X dev; I probably meant to not only mention it as the only way to surface deprecation warnings.

@vstinner

vstinner commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

I think it's also worth mentioning -X dev; I probably meant to not only mention it as the only way to surface deprecation warnings.

Ok, done.

@vstinner @hugovk
Update Doc/whatsnew/3.9.rst …
d156a3d 
Co-Authored-By: Hugo van Kemenade <hugovk@users.noreply.github.com>
@vstinner vstinner merged commit 116fd4a into python:master Mar 3, 2020
@vstinner vstinner deleted the warn branch March 3, 2020 21:52
@vstinner

vstinner commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

Thanks @hugovk for your useful reviews!

@hugovk

hugovk commented Mar 3, 2020

Copy link
Copy Markdown
Member

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @brettcannon @hugovk @the-knights-who-say-ni @bedevere-bot