◐ Shell
reader mode source ↗
Skip to content

bpo-17422:language reference should specify restrictions on class namespace#18559

Merged
gvanrossum merged 12 commits into
python:masterfrom
ananthan-123:namespace
Feb 22, 2020
Merged

bpo-17422:language reference should specify restrictions on class namespace#18559
gvanrossum merged 12 commits into
python:masterfrom
ananthan-123:namespace

Conversation

@ananthan-123

@ananthan-123 ananthan-123 commented Feb 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 19, 2020
@mdickinson mdickinson removed their request for review February 19, 2020 18:27
brandtbucher
brandtbucher requested changes Feb 21, 2020
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @ananthan-123. No need to request reviews from 3 triagers and 4 core developers though, that's bordering on spam (especially if they have nothing to do with the issue/patch). One request should be fine, maybe a second if the first person doesn't respond after a week or two.

A few things I spotted here (I'm assuming that the wording in Eric's original patch from 7 years ago is correct):

32 hidden items Load more…
brandtbucher
brandtbucher approved these changes Feb 21, 2020
View reviewed changes

@brandtbucher brandtbucher left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good now. @ericsnowcurrently, care to review the content for this? It's your issue.

brandtbucher
brandtbucher requested changes Feb 21, 2020
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Sorry, one more thing...

@ananthan-123 @brandtbucher
Update Misc/NEWS.d/next/Documentation/2020-02-19-11-13-47.bpo-17422.g… …
1c648cd 
…7_9zz.rst

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@gvanrossum gvanrossum merged commit fbe2e0b into python:master Feb 22, 2020
@bedevere-bot

bedevere-bot commented Feb 22, 2020

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Feb 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 22, 2020

Copy link
Copy Markdown

GH-18610 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2020
@ananthan-123 @miss-islington
bpo-17422: Language reference should specify restrictions on class na… …
dd99fb4 
…mespace (pythonGH-18559)

The language reference now specifies restrictions on class namespaces.  Adapted from a patch by Ethan Furman.
(cherry picked from commit fbe2e0b)

Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 22, 2020

Copy link
Copy Markdown

GH-18611 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 22, 2020
@miss-islington @ananthan-123
bpo-17422: Language reference should specify restrictions on class na… …
91ba446 
…mespace (GH-18559)

The language reference now specifies restrictions on class namespaces.  Adapted from a patch by Ethan Furman.
(cherry picked from commit fbe2e0b)

Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>
miss-islington added a commit that referenced this pull request Feb 22, 2020
@miss-islington @ananthan-123
bpo-17422: Language reference should specify restrictions on class na… …
36a120d 
…mespace (GH-18559)

The language reference now specifies restrictions on class namespaces.  Adapted from a patch by Ethan Furman.
(cherry picked from commit fbe2e0b)

Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

+1 more reviewer

@cdonovick cdonovick cdonovick left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ananthan-123 @bedevere-bot @miss-islington @ericsnowcurrently @gvanrossum @cdonovick @brandtbucher @the-knights-who-say-ni