◐ Shell
reader mode source ↗
Skip to content

gh-64490: varargs support for argument clinic and refactor print with AC#18609

Merged
isidentical merged 1 commit into
python:mainfrom
isidentical:bpo-20291
Jul 16, 2021
Merged

gh-64490: varargs support for argument clinic and refactor print with AC#18609
isidentical merged 1 commit into
python:mainfrom
isidentical:bpo-20291

Conversation

@isidentical

@isidentical isidentical commented Feb 22, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • f(*args, /)
  • f(x, y, *args, /)
  • f(*args)
  • f(x, y, *args)
  • f(x, /, y, *args)
  • f(x, *args, y=3)
  • f(*args, y=3, z=5)

https://bugs.python.org/issue20291

@isidentical isidentical changed the title [WIP] varargs support for argument clinic Feb 23, 2020
@isidentical isidentical force-pushed the bpo-20291 branch 4 times, most recently from 8dca07a to 239ad97 Compare February 24, 2020 17:07
@isidentical isidentical changed the title [WIP] varargs support for argument clinic and refactor print with AC Feb 24, 2020
@isidentical isidentical force-pushed the bpo-20291 branch 5 times, most recently from 0ae57a2 to deef95c Compare February 26, 2020 12:31
@codecov

codecov Bot commented Feb 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18609 into master will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18609       +/-   ##
===========================================
+ Coverage   82.08%   83.20%    +1.12%     
===========================================
  Files        1956     1571      -385     
  Lines      589394   414936   -174458     
  Branches    44457    44482       +25     
===========================================
- Hits       483778   345267   -138511     
+ Misses      95969    60023    -35946     
+ Partials     9647     9646        -1
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 446 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dee92b...deef95c. Read the comment docs.

@isidentical isidentical marked this pull request as ready for review February 26, 2020 16:08
@isidentical isidentical changed the title [WIP] bpo-20291: varargs support for argument clinic and refactor print with AC Feb 26, 2020
@serhiy-storchaka serhiy-storchaka self-requested a review March 14, 2020 10:23
serhiy-storchaka
serhiy-storchaka reviewed Mar 14, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Interesting PR. Thank you that taken this issue Batuhan! 👍 But it will take a time to make a review.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 14, 2020
@pablogsal

pablogsal commented Jun 3, 2021

Copy link
Copy Markdown
Member

@serhiy-storchaka Could you review this PR if you have the time? If you are busy I can finish the review myself and try to land it so it reaches 3.11 :)

@pablogsal

pablogsal commented Jul 13, 2021

Copy link
Copy Markdown
Member

@isidentical Can you rebase this and we can land it?

@isidentical isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 13, 2021
@bedevere-bot

bedevere-bot commented Jul 13, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 4186327 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 13, 2021
@pablogsal

pablogsal commented Jul 13, 2021

Copy link
Copy Markdown
Member

@isidentical Land if the buildbots are happy. Don't forget to also change the docs for the argument clinic in the devguide with any updates!

@isidentical isidentical merged commit 9af34c9 into python:main Jul 16, 2021
@sweeneyde sweeneyde mentioned this pull request Dec 31, 2021
Merged
@colorfulappl colorfulappl mentioned this pull request Mar 24, 2022
Merged
@larryhastings larryhastings mentioned this pull request Apr 10, 2022
Open
@gpshead gpshead changed the title bpo-20291: varargs support for argument clinic and refactor print with AC Feb 7, 2023
@gpshead

gpshead commented Feb 7, 2023

Copy link
Copy Markdown
Member

The Doc/howto/clinic.rst docs still need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@pablogsal pablogsal pablogsal approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isidentical @pablogsal @bedevere-bot @gpshead @serhiy-storchaka @the-knights-who-say-ni