◐ Shell
reader mode source ↗
Skip to content

bpo-39704: Explicitly pass path to codecov config#18680

Merged
brettcannon merged 1 commit into
python:masterfrom
ammaraskar:disable_codecov_comments
Feb 27, 2020
Merged

bpo-39704: Explicitly pass path to codecov config#18680
brettcannon merged 1 commit into
python:masterfrom
ammaraskar:disable_codecov_comments

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Feb 27, 2020 •
edited by brettcannon
Loading

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Feb 27, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18680 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18680       +/-   ##
===========================================
+ Coverage   82.13%   83.21%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589854   415170   -174684     
  Branches    44477    44477               
===========================================
- Hits       484456   345490   -138966     
+ Misses      95749    60032    -35717     
+ Partials     9649     9648        -1
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 440 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374d998...e65b5a0. Read the comment docs.

@brettcannon brettcannon merged commit 766b754 into python:master Feb 27, 2020
@miss-islington

miss-islington commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @ammaraskar for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @ammaraskar for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Sorry, @ammaraskar and @brettcannon, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 766b7546a564c8e386a3c31eb06fc1b55e8f5a25 3.7

@miss-islington

miss-islington commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Sorry @ammaraskar and @brettcannon, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 766b7546a564c8e386a3c31eb06fc1b55e8f5a25 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

@brettcannon brettcannon

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ammaraskar @miss-islington @brettcannon @the-knights-who-say-ni @bedevere-bot