◐ Shell
reader mode source ↗
Skip to content

bpo-10572: Move tkinter tests to /test#18727

Closed
idomic wants to merge 3 commits into
python:mainfrom
idomic:bpo-10572-testlibs
Closed

bpo-10572: Move tkinter tests to /test#18727
idomic wants to merge 3 commits into
python:mainfrom
idomic:bpo-10572-testlibs

Conversation

@idomic

@idomic idomic commented Mar 1, 2020 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

@idomic idomic changed the title Moving tests - clean start - tkinter, sqlite3, ctypes Mar 1, 2020
berkerpeksag
berkerpeksag requested changes Mar 2, 2020
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please do not touch sqlite3 tests. It needs more work than just moving things around.

Also, submitting separate PRs for each module would increase the chance of getting them accepted.

@bedevere-bot

bedevere-bot commented Mar 2, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@idomic idomic force-pushed the bpo-10572-testlibs branch from d659ed4 to ffa202d Compare March 15, 2020 14:44
@idomic

idomic commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Mar 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

terryjreedy
terryjreedy requested changes Sep 6, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I don't think that the actual tkinter tests should be installed unless tkinter is installed. So I don't think that tkinter tests should be changed. I certainly would not do so unless Serhiy wants the move and approves of how it is done.

EDIT: So I am actually suggesting that this be closed and that you pick something else to move that is always installed.

@bedevere-bot

bedevere-bot commented Sep 6, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedy terryjreedy changed the title bpo-10572: Moving tests - clean start - tkinter, sqlite3, ctypes Jul 15, 2021
@rhettinger rhettinger removed their request for review May 3, 2022 06:30
@voidspace voidspace mentioned this pull request Jun 20, 2022
Closed
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

This was implemented in #94070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@terryjreedy terryjreedy terryjreedy requested changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@idomic @bedevere-bot @erlend-aasland @berkerpeksag @merwok @terryjreedy @the-knights-who-say-ni @ezio-melotti