◐ Shell
reader mode source ↗
Skip to content

bpo-39682: make pathlib.Path immutable by removing (undocumented) support for "closing" a path by using it as a context manager#18846

Merged
pitrou merged 2 commits into
python:masterfrom
barneygale:bpo-39682-pathlib-path-context-manager
Apr 1, 2020
Merged

bpo-39682: make pathlib.Path immutable by removing (undocumented) support for "closing" a path by using it as a context manager#18846
pitrou merged 2 commits into
python:masterfrom
barneygale:bpo-39682-pathlib-path-context-manager

Conversation

@barneygale

@barneygale barneygale commented Mar 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This implements @pitrou's suggestion of retaining support for using a Path object as a context manager, but making it a no-op.

https://bugs.python.org/issue39682

@the-knights-who-say-ni

the-knights-who-say-ni commented Mar 8, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@barneygale

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

pitrou
pitrou requested changes Mar 8, 2020
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

+1 on the principle, but I don't think we should remove the test entirely, just change it.
Also, please add a NEWS entry. You can do so using blurb or blurb-it.

@bedevere-bot

bedevere-bot commented Mar 8, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale barneygale force-pushed the bpo-39682-pathlib-path-context-manager branch from 626c970 to c89a62d Compare March 8, 2020 10:51
@barneygale

barneygale commented Mar 8, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again. Thank you!

@bedevere-bot

bedevere-bot commented Mar 8, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from pitrou March 8, 2020 11:02
pitrou
pitrou approved these changes Mar 8, 2020
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

+1. Have you signed the CLA?

@barneygale

barneygale commented Mar 8, 2020

Copy link
Copy Markdown
Contributor Author

I have! I think it's just making its way through the system currently.

@pitrou

pitrou commented Mar 8, 2020

Copy link
Copy Markdown
Member

Cool, thank you. I'll wait for the bot to notice, then :-)

brettcannon
brettcannon requested changes Mar 9, 2020
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Quick request to document in the code why this change is being made, else someone else in the future may be wondering why it's a no-op.

@bedevere-bot

bedevere-bot commented Mar 9, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale barneygale force-pushed the bpo-39682-pathlib-path-context-manager branch from 19bea17 to b260194 Compare March 10, 2020 00:05
@barneygale

barneygale commented Mar 10, 2020

Copy link
Copy Markdown
Contributor Author

Thank you Brett. I have made the requested changes; please review again. Hope the comment isn't too long.

@bedevere-bot

bedevere-bot commented Mar 10, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon, @pitrou: please review the changes made to this pull request.

16 hidden items Load more…
@bedevere-bot

bedevere-bot commented Mar 10, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale barneygale force-pushed the bpo-39682-pathlib-path-context-manager branch from 86cf4dc to ca3acfd Compare March 21, 2020 01:50
@barneygale

barneygale commented Mar 21, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Mar 21, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@pitrou, @brettcannon: please review the changes made to this pull request.

pitrou
pitrou approved these changes Mar 28, 2020
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

+1 for this, thank you @barneygale .
I'll leave this open a day or two in case people hold strong opinions about deprecating this silent behaviour.

@bedevere-bot bedevere-bot added awaiting merge and removed labels Mar 28, 2020
@pitrou

pitrou commented Mar 28, 2020

Copy link
Copy Markdown
Member

@barneygale Can you rebase/merge from master to re-run CI on this?

@barneygale @brettcannon
bpo-39682: make pathlib.Path immutable by removing (undocumented) s… …
31c116a 
…upport for "closing" a path by using it as a context manager.

Support for using a path as a context manager remains, and is now a no-op.

Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
@barneygale barneygale force-pushed the bpo-39682-pathlib-path-context-manager branch from ca3acfd to 31c116a Compare March 29, 2020 19:34
@barneygale

barneygale commented Mar 29, 2020

Copy link
Copy Markdown
Contributor Author

Rebased on master. Thanks @pitrou and @brettcannon for helping get this through :)

@barneygale @aeros
Update Misc/NEWS.d/next/Library/2020-03-08-11-00-01.bpo-39682.AxXZNz.rst …
d9aa9df 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
aeros
aeros approved these changes Mar 30, 2020
View reviewed changes

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @barneygale; LGTM.

@brettcannon

brettcannon commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I have an opinion about deprecation, but it isn't strong. 😄 Basically I'm worried someone out there is relying on this functionality and is going to be caught off-guard that it suddenly stopped working. But as I said, I'm +0 on the deprecation so I won't hold up the PR if people disagree.

@pitrou pitrou merged commit 00002e6 into python:master Apr 1, 2020
@barneygale barneygale mentioned this pull request Apr 3, 2020
Merged
@barneygale

barneygale commented Apr 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Just noting that I have a follow-up PR - #19342 - that removes the _init() method that was touched by this PR.

@barneygale barneygale mannequin mentioned this pull request Apr 10, 2022
Closed
@04d4 04d4 mentioned this pull request Jul 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

+1 more reviewer

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@barneygale @the-knights-who-say-ni @bedevere-bot @pitrou @brettcannon @aeros