◐ Shell
reader mode source ↗
Skip to content

Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable#1887

Closed
pitrou wants to merge 1 commit into
python:masterfrom
pitrou:writable_line_buffering
Closed

Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable#1887
pitrou wants to merge 1 commit into
python:masterfrom
pitrou:writable_line_buffering

Conversation

@pitrou

@pitrou pitrou commented May 31, 2017

Copy link
Copy Markdown
Member

This simplifies the reconfiguration of standard streams as it can now be done in-place.

@pitrou
Fix python#30526: make TextIOWrapper.{line_buffering, write_through} … …
2fbc916 
…writable

This simplifies the reconfiguration of standard streams as it can now be done in-place.
@pitrou pitrou requested a review from benjaminp May 31, 2017 16:47
@mention-bot

mention-bot commented May 31, 2017

Copy link
Copy Markdown

@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers.

@pitrou pitrou changed the title Fix #30526: make TextIOWrapper.{line_buffering, write_through} writable May 31, 2017
@pitrou pitrou added the type-feature A feature request or enhancement label May 31, 2017
@pitrou

pitrou commented May 31, 2017

Copy link
Copy Markdown
Member Author

The AppVeyor failure is unrelated.

benjaminp
benjaminp reviewed Jun 1, 2017
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

so what happens when I set line_buffering = True and write_through = True?

@pitrou

pitrou commented Jun 2, 2017

Copy link
Copy Markdown
Member Author

#1922 is now preferred.

@pitrou

pitrou commented Jun 2, 2017

Copy link
Copy Markdown
Member Author

so what happens when I set line_buffering = True and write_through = True?

Same as before: write_through takes precedence (everything is written through).

@pitrou

pitrou commented Jun 6, 2017

Copy link
Copy Markdown
Member Author

Superseded by #1922.

@pitrou pitrou closed this Jun 6, 2017
@pitrou pitrou deleted the writable_line_buffering branch June 6, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp left review comments

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @mention-bot @benjaminp @the-knights-who-say-ni