◐ Shell
reader mode source ↗
Skip to content

Rename Doc/README.txt to Doc/README.rst#19

Closed
ghost wants to merge 5 commits into
masterfrom
unknown repository
Closed

Rename Doc/README.txt to Doc/README.rst#19
ghost wants to merge 5 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 11, 2017

Copy link
Copy Markdown

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@methane

methane commented Feb 11, 2017

Copy link
Copy Markdown
Member

I think we don't require CLA sign for pull requests like this.

@orsenthil

Copy link
Copy Markdown
Member

@methane , any patch / contribution requires CLA sign.

@ghost

ghost commented Feb 11, 2017

Copy link
Copy Markdown
Author

I signed it an hour ago.

@methane

methane commented Feb 11, 2017

Copy link
Copy Markdown
Member

Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)

@berkerpeksag berkerpeksag added the label Feb 11, 2017

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.

@ghost

ghost commented Feb 12, 2017

Copy link
Copy Markdown
Author

@methane MY CLA still has not been marked, and I currently have this:

image

It's been two days since I submitted it, any update?

@vstinner

Copy link
Copy Markdown
Member

Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch.

@ghost

ghost commented Feb 12, 2017

Copy link
Copy Markdown
Author

No, it was made in the master branch @Haypo

@ghost

ghost commented Feb 12, 2017

Copy link
Copy Markdown
Author

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

@vstinner

Copy link
Copy Markdown
Member

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

Look at README.rst in the root directory.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I suggested different text where [...] is the link.

@ghost

ghost commented Feb 13, 2017

Copy link
Copy Markdown
Author

The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is narayan<>roger<>@<>gmail.com (remove the <>)

@codecov

codecov Bot commented Feb 13, 2017

Copy link
Copy Markdown

Codecov Report

Merging #19 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289091   289089       -2     
- Misses      61857    61859       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29896ad...08cb2a3. Read the comment docs.

@ghost

ghost commented Feb 13, 2017

Copy link
Copy Markdown
Author

@Haypo The changes you requested were made

7 hidden items Load more…
paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Feb 1, 2023
19: Warn for range and xrange r=ltratt a=nanjekyejoannah

See notes:

```
Py2.x:

>>> x = xrange(1, 10000)
>>> a = range(1,10000)
>>> type(a)
<type 'list'>
>>> 

Py3.x:

>>> x = xrange(1, 10000)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'xrange' is not defined
>>> a = range(1,10000)
>>> type(a)
<class 'range'>
>>> 
```

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
* fix: off by one error in forward jump calculation

* Test: fixed test for python#18

* test: remove broken test

---------

Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
youknowone referenced this pull request in youknowone/cpython Nov 20, 2025
There are still some issues with compilation, but those can be sorted out in a future PR.
ZeroIntensity pushed a commit to ZeroIntensity/cpython that referenced this pull request Dec 8, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants