◐ Shell
reader mode source ↗
Skip to content

bpo-39981: Default values for AST nodes#19031

Closed
isidentical wants to merge 5 commits into
python:masterfrom
isidentical:bpo-39981
Closed

bpo-39981: Default values for AST nodes#19031
isidentical wants to merge 5 commits into
python:masterfrom
isidentical:bpo-39981

Conversation

@isidentical

@isidentical isidentical commented Mar 16, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal requested changes Mar 16, 2020
View reviewed changes
1 hidden conversation Load more…
@bedevere-bot

bedevere-bot commented Mar 16, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal

pablogsal commented Mar 16, 2020

Copy link
Copy Markdown
Member

Some initial comments, without commenting on the approach itself.

@serhiy-storchaka should confirm that he is happy with this approach as he was working on some related functionality.

@isidentical isidentical added the type-feature A feature request or enhancement label Mar 17, 2020
@isidentical

isidentical commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Mar 17, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from pablogsal March 17, 2020 07:21
@isidentical isidentical force-pushed the bpo-39981 branch 2 times, most recently from 9cdb15f to 0cbc2a8 Compare March 18, 2020 09:39
@isidentical

isidentical commented Apr 22, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka It would be awesome to have your review / thoughts on this before alpha cut.

@isidentical

isidentical commented Jul 9, 2020

Copy link
Copy Markdown
Member Author

Closing this in favor of #21417

@isidentical isidentical closed this Jul 9, 2020
@isidentical isidentical mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting change review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isidentical @bedevere-bot @pablogsal