◐ Shell
reader mode source ↗
Skip to content

bpo-1635741: Port _collections module to multiphase initialization. #19074

Merged
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-1635741-_collectionsmodule
Mar 19, 2020
Merged

bpo-1635741: Port _collections module to multiphase initialization. #19074
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-1635741-_collectionsmodule

Conversation

@corona10

@corona10 corona10 commented Mar 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from rhettinger as a code owner March 19, 2020 15:21
@corona10

corona10 commented Mar 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

For the record, I will work on a new helper function after this PR is landed if this work is worth to do.
#19071 (comment)

@corona10 corona10 requested a review from vstinner March 19, 2020 15:40
@corona10

corona10 commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

@shihai1991 Please take a look :)

vstinner
vstinner approved these changes Mar 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM apart "m" variable name which looks too short to me ;-)

@shihai1991

shihai1991 commented Mar 19, 2020

Copy link
Copy Markdown
Member

oh, on~ my network crashed at this point :(
I can not review codes now, waiting a moment~

shihai1991
shihai1991 approved these changes Mar 19, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I like the improvment of typelist.
LGTM :)

@corona10

corona10 commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

@vstinner @shihai1991

Thanks for the reviews :)

@vstinner vstinner merged commit 77248a2 into python:master Mar 19, 2020
@corona10 corona10 deleted the bpo-1635741-_collectionsmodule branch March 31, 2020 12:49
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@shihai1991 shihai1991 shihai1991 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot