◐ Shell
reader mode source ↗
Skip to content

Fix bpo-30526: Add TextIOWrapper.reconfigure()#1922

Merged
pitrou merged 4 commits into
python:masterfrom
pitrou:reconfigure_textiowrapper
Jun 3, 2017
Merged

Fix bpo-30526: Add TextIOWrapper.reconfigure()#1922
pitrou merged 4 commits into
python:masterfrom
pitrou:reconfigure_textiowrapper

Conversation

@pitrou

@pitrou pitrou commented Jun 2, 2017

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

mention-bot commented Jun 2, 2017

Copy link
Copy Markdown

@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers.

@pitrou pitrou mentioned this pull request Jun 2, 2017
Closed
@pitrou

pitrou commented Jun 2, 2017

Copy link
Copy Markdown
Member Author

@ncoghlan

ncoghlan
ncoghlan approved these changes Jun 3, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The actual change mostly looks good to me (just one comment on the specifics of the docs wording).

The commit message should make sure to explain that this doesn't just cover adding reconfigure, it also adds a read-only property to read back the write_through status that was set in either the constructor or the last call to reconfigure().

@pitrou pitrou merged commit 3c2817b into python:master Jun 3, 2017
@pitrou pitrou deleted the reconfigure_textiowrapper branch June 3, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @mention-bot @ncoghlan @the-knights-who-say-ni