bpo-40121: Fixes audit events raised on creating a new socket#19238

zooba

https://bugs.python.org/issue40121

miss-islington

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

…H-19238) (cherry picked from commit 63ba5cc) Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot

GH-19241 is a backport of this pull request to the 3.8 branch.

(cherry picked from commit 63ba5cc) Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.x has failed when building commit 63ba5cc.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/336/builds/328) and take a look at the build logs.
Check if the failure is related to this commit (63ba5cc) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/336/builds/328

Failed tests:

test_audit

Failed subtests:

test_socket - test.test_audit.AuditTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

404 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 34 sec
test_multiprocessing_spawn: 1 min 46 sec
test_multiprocessing_forkserver: 1 min 20 sec
test_multiprocessing_fork: 1 min 5 sec
test_tokenize: 1 min 5 sec
test_nntplib: 1 min 5 sec
test_capi: 1 min 3 sec
test_unparse: 1 min 3 sec
test_asyncio: 55.9 sec
test_gdb: 55.8 sec

1 test failed:
test_audit

15 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_readline test_startfile test_tix test_tk
test_ttk_guionly test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_audit

Total duration: 5 min 58 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/audit-tests.py", line 358, in <module>
    globals()[test]()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/audit-tests.py", line 346, in test_socket
    except error:
NameError: name 'error' is not defined


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/audit-tests.py", line 345, in test_socket
    sock.bind(('127.0.0.1', 8080))
OSError: [Errno 98] Address already in use


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/test_audit.py", line 125, in test_socket
    self.fail(stderr)
AssertionError

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.x has failed when building commit 63ba5cc.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/505/builds/206) and take a look at the build logs.
Check if the failure is related to this commit (63ba5cc) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/505/builds/206

Failed tests:

test_audit

Failed subtests:

test_socket - test.test_audit.AuditTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

400 tests OK.

1 test failed:
test_audit

19 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_readline test_startfile test_tix test_tk
test_ttk_guionly test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_audit

Total duration: 4 min

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/audit-tests.py", line 345, in test_socket
    sock.bind(('127.0.0.1', 8080))
OSError: [Errno 98] Address already in use


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/audit-tests.py", line 358, in <module>
    globals()[test]()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/audit-tests.py", line 346, in test_socket
    except error:
NameError: name 'error' is not defined
FAIL


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/audit-tests.py", line 358, in <module>
    globals()[test]()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/audit-tests.py", line 346, in test_socket
    except error:
NameError: name 'error' is not defined


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.9/test/test_audit.py", line 125, in test_socket
    self.fail(stderr)
AssertionError

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.x has failed when building commit 63ba5cc.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/460/builds/205) and take a look at the build logs.
Check if the failure is related to this commit (63ba5cc) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/460/builds/205

Failed tests:

test_audit

Failed subtests:

test_socket - test.test_audit.AuditTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

403 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 25 sec
test_multiprocessing_spawn: 1 min 31 sec
test_multiprocessing_forkserver: 1 min 14 sec
test_multiprocessing_fork: 1 min 6 sec
test_nntplib: 1 min 4 sec
test_signal: 47.2 sec
test_asyncio: 42.1 sec
test_io: 33.9 sec
test_pydoc: 30.8 sec
test_tokenize: 29.5 sec

1 test failed:
test_audit

16 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_readline test_startfile test_tix test_tk
test_ttk_guionly test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_audit

Total duration: 4 min 52 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/test/test_audit.py", line 125, in test_socket
    self.fail(stderr)
AssertionError


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/test/audit-tests.py", line 358, in <module>
    globals()[test]()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/test/audit-tests.py", line 346, in test_socket
    except error:
NameError: name 'error' is not defined


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto-pgo/build/Lib/test/audit-tests.py", line 345, in test_socket
    sock.bind(('127.0.0.1', 8080))
OSError: [Errno 98] Address already in use

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit 63ba5cc.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/500/builds/204) and take a look at the build logs.
Check if the failure is related to this commit (63ba5cc) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/500/builds/204

Failed tests:

test_audit

Failed subtests:

test_socket - test.test_audit.AuditTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

404 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 41 sec
test_gdb: 1 min 33 sec
test_multiprocessing_spawn: 1 min 29 sec
test_multiprocessing_forkserver: 1 min 9 sec
test_nntplib: 1 min 5 sec
test_multiprocessing_fork: 1 min 3 sec
test_signal: 47.4 sec
test_asyncio: 42.0 sec
test_io: 35.7 sec
test_tokenize: 33.1 sec

1 test failed:
test_audit

15 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_readline test_startfile test_tix test_tk
test_ttk_guionly test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_audit

Total duration: 4 min 9 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_audit.py", line 125, in test_socket
    self.fail(stderr)
AssertionError


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/audit-tests.py", line 345, in test_socket
    sock.bind(('127.0.0.1', 8080))
OSError: [Errno 98] Address already in use


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/audit-tests.py", line 358, in <module>
    globals()[test]()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/audit-tests.py", line 346, in test_socket
    except error:
NameError: name 'error' is not defined

bpo-40121: Fixes audit events raised on creating a new socket

7db9f7f

zooba added type-bug An unexpected behavior, bug, or error needs backport to 3.8 labels Mar 30, 2020

the-knights-who-say-ni added the CLA signed label Mar 30, 2020

bedevere-bot added the awaiting core review label Mar 30, 2020

zooba added 3 commits March 31, 2020 00:00

These should not be needed

95dffb8

Verbose output in test

ae7b37d

Fixes condition for Windows

c80d532

zooba merged commit 63ba5cc into python:master Mar 31, 2020

bedevere-bot removed the awaiting core review label Mar 31, 2020

zooba deleted the bpo-40121 branch March 31, 2020 11:39

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 31, 2020

bpo-40121: Fixes audit event raised on creating a new socket (pythonG… …

5220eba

…H-19238) (cherry picked from commit 63ba5cc) Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot removed the needs backport to 3.8 label Mar 31, 2020

miss-islington added a commit that referenced this pull request Mar 31, 2020

bpo-40121: Fixes audit event raised on creating a new socket (GH-19238) …

6a0ee60

(cherry picked from commit 63ba5cc) Co-authored-by: Steve Dower <steve.dower@python.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-40121: Fixes audit events raised on creating a new socket#19238