◐ Shell
reader mode source ↗
Skip to content

bpo-40105: Truncating file if opened in append mode.#19337

Merged
taleinat merged 7 commits into
python:masterfrom
mzr:zipfile-shorten-comment-fix
Sep 28, 2020
Merged

bpo-40105: Truncating file if opened in append mode.#19337
taleinat merged 7 commits into
python:masterfrom
mzr:zipfile-shorten-comment-fix

Conversation

@mzr

@mzr mzr commented Apr 3, 2020 •
edited by taleinat
Loading

Copy link
Copy Markdown
Contributor

Implemented a test for this behaviour.

If we just truncate the test fails for Unseekable file types. In current implementation, those type of files can't be opened in the append ('a') mode anyway, so we could make a check for that in the future.

https://bugs.python.org/issue40105

@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 3, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mzr

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@mzr mzr changed the title Truncating file if opened in append mode. Apr 3, 2020
@disconnect3d disconnect3d mentioned this pull request Apr 3, 2020
Closed
taleinat
taleinat requested changes Sep 26, 2020
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks good! Just a couple of minor comments regarding the test.

@bedevere-bot

bedevere-bot commented Sep 26, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mzr

mzr commented Sep 28, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Sep 28, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat
taleinat approved these changes Sep 28, 2020
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good!

@taleinat taleinat merged commit ff9147d into python:master Sep 28, 2020
@miss-islington

miss-islington commented Sep 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @mzr for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2020
@mzr @miss-islington
bpo-40105: ZipFile truncate in append mode with shorter comment (pyth… …
b5420ed 
…onGH-19337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <16736821+mzr@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Sep 28, 2020

Copy link
Copy Markdown

GH-22436 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2020
@mzr @miss-islington
bpo-40105: ZipFile truncate in append mode with shorter comment (pyth… …
bf9ac46 
…onGH-19337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <16736821+mzr@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Sep 28, 2020

Copy link
Copy Markdown

GH-22437 is a backport of this pull request to the 3.8 branch.

@mzr mzr deleted the zipfile-shorten-comment-fix branch September 28, 2020 19:04
miss-islington added a commit that referenced this pull request Sep 28, 2020
@miss-islington @mzr
bpo-40105: ZipFile truncate in append mode with shorter comment (GH-1… …
e400840 
…9337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <16736821+mzr@users.noreply.github.com>
@miss-islington

miss-islington commented Sep 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @mzr for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2020
@mzr @miss-islington
bpo-40105: ZipFile truncate in append mode with shorter comment (pyth… …
6f1efdd 
…onGH-19337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <16736821+mzr@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Sep 28, 2020

Copy link
Copy Markdown

GH-22439 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 28, 2020
@miss-islington @mzr
bpo-40105: ZipFile truncate in append mode with shorter comment (GH-1… …
048f54d 
…9337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <16736821+mzr@users.noreply.github.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 29, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1 …
e3b9365 
* origin/master: (113 commits)
  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)
  bpo-41873: Add vectorcall for float() (pythonGH-22432)
  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)
  bpo-41842: Add codecs.unregister() function (pythonGH-22360)
  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)
  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)
  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)
  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)
  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)
  bpo-41858: Clarify line in optparse doc (pythonGH-22407)
  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)
  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)
  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)
  Fix logging error message (pythonGH-22410)
  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)
  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)
  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@mzr @xzy3-cdc
bpo-40105: ZipFile truncate in append mode with shorter comment (pyth… …
ef4596e 
…onGH-19337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mzr @the-knights-who-say-ni @bedevere-bot @miss-islington @taleinat