◐ Shell
reader mode source ↗
Skip to content

bpo-40173: Remove redundant import module of import_fresh_module()#19390

Closed
shihai1991 wants to merge 1 commit into
python:mainfrom
shihai1991:bpo_40173
Closed

bpo-40173: Remove redundant import module of import_fresh_module()#19390
shihai1991 wants to merge 1 commit into
python:mainfrom
shihai1991:bpo_40173

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 6, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@shihai1991 shihai1991 changed the title WIP: Remove redundant import module of import_fresh_module() Apr 6, 2020
iritkatriel
iritkatriel reviewed Aug 24, 2020
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This PR needs a unit test.

@shihai1991

shihai1991 commented Aug 24, 2020

Copy link
Copy Markdown
Member Author

This PR needs a unit test.

Thanks for your comment. I have forget this PR's detail. test.support need many test cases.
After we make sure this PR can fix the issue, I can add some test cases.

@iritkatriel

iritkatriel commented Aug 24, 2020

Copy link
Copy Markdown
Member

Up to you, but I think it will be easier for reviewers to see what issue the PR is trying to fix if it included tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shihai1991 @iritkatriel @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot