◐ Shell
reader mode source ↗
Skip to content

bpo-40077: Remove redundant cast in _json extension module#19438

Merged
corona10 merged 1 commit into
python:masterfrom
shihai1991:bpo_40077_json
Apr 9, 2020
Merged

bpo-40077: Remove redundant cast in _json extension module#19438
corona10 merged 1 commit into
python:masterfrom
shihai1991:bpo_40077_json

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@shihai1991

shihai1991 commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

@corona10 Hi, Dong-hee Na, congratulations!

this cast is redundant, right?

corona10
corona10 approved these changes Apr 9, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for catching this :)
Since PyScannerType and PyEncoderType is PyObject*.
Casting is unnecessary things.

lgtm!

@corona10 corona10 requested a review from vstinner April 9, 2020 14:02
@corona10

corona10 commented Apr 9, 2020

Copy link
Copy Markdown
Member

cc @vstinner

@shihai1991

shihai1991 commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

Thanks for catching this :)
Since PyScannerType and PyEncoderType is PyObject*.
Casting is unnecessary things.

lgtm!

Thanks, MAYBE you can try use your merge right in this PR ;)

vstinner
vstinner approved these changes Apr 9, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Usually, we don't accept coding style only changes. But I think that it's ok to make an exception here.

@corona10 corona10 merged commit dcb04d9 into python:master Apr 9, 2020
@vstinner

vstinner commented Apr 9, 2020

Copy link
Copy Markdown
Member

@corona10: Congrats for your first merge ;-)

@corona10

corona10 commented Apr 9, 2020

Copy link
Copy Markdown
Member

@vstinner Thank you, it is the singularity of life

@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shihai1991 @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot