bpo-40366: Remove support for passing obsolete flags into compile#19660
bpo-40366: Remove support for passing obsolete flags into compile#19660isidentical wants to merge 2 commits into
Conversation
vstinner
left a comment
There was a problem hiding this comment.
If CO_NESTED is no longer useful, why not removing the flag rather than adding a complicated deprecated code path? Passing flags to compile() is uncommon.
@serhiy-storchaka: Do you think that a deprecation period is needed?
Since how long CO_NESTED does nothing?
Sorry, something went wrong.
|
Sorry, something went wrong.
|
Oh. If CO_NESTED is useless since Python 2.2 which was released 19 years ago, it's maybe time to remove it. |
Sorry, something went wrong.
|
Does this removal will cover disallowing |
Sorry, something went wrong.
I don't see any benefit from removing this import: it doesn't reduce the Python maintenance burden, it just breaks existing applications for free. Most |
Sorry, something went wrong.
|
FWIW, removal of |
Sorry, something went wrong.
In that case, I think we can close the PR. @isidentical What are your thoughts on this? |
Sorry, something went wrong.
Let met close this old inactive PR. |
Sorry, something went wrong.
This PR also removes a case related
CO_GENERATOR_ALLOWED(which was also unusable, and totally purged in #19230)https://bugs.python.org/issue40366