◐ Shell
reader mode source ↗
Skip to content

bpo-40334: Support CO_FUTURE_BARRY_AS_BDFL in the new parser#19721

Merged
pablogsal merged 7 commits into
python:masterfrom
pablogsal:bpo-40334-barry
Apr 27, 2020
Merged

bpo-40334: Support CO_FUTURE_BARRY_AS_BDFL in the new parser#19721
pablogsal merged 7 commits into
python:masterfrom
pablogsal:bpo-40334-barry

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@pablogsal

pablogsal commented Apr 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Most of the code is threading down the flags to the parser (commit
784d851) and fix a bug when inlining actions (commit 770fd11). The actual fix is implemented in commit
c970217.
In the future when we don't need to have compatibility with the old parser, we can make the tokenizer return a different token for "<>" and then intercept that in the parser in another alternative.

@gvanrossum

gvanrossum commented Apr 26, 2020

Copy link
Copy Markdown
Member

Is this needed for alpha 6?

@pablogsal

pablogsal commented Apr 26, 2020

Copy link
Copy Markdown
Member Author

Is this needed for alpha 6?

Nop

gvanrossum
gvanrossum reviewed Apr 27, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for all the work here for threading through the flags! I think that might solve one of my problems with type comments.

pablogsal and others added 2 commits April 27, 2020 17:05
@pablogsal @gvanrossum
Update Parser/pegen/pegen.c …
49a6772 
Co-Authored-By: Guido van Rossum <gvanrossum@gmail.com>
@pablogsal
Address feedback
a1f0b03
gvanrossum
gvanrossum approved these changes Apr 27, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Go ahead, maybe we'll make the alpha yet!

@pablogsal pablogsal merged commit 2b74c83 into python:master Apr 27, 2020
@pablogsal pablogsal deleted the bpo-40334-barry branch May 19, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure in test_flufl: '<>' raises SyntaxError even with CO_FUTURE_BARRY_AS_BDFL

4 participants

@pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot