{{ message }}
bpo-40334: refactor and cleanup for the PEG generators#19775
Merged
pablogsal merged 3 commits intoApr 29, 2020
Merged
Conversation
8542748 to
be64838
Compare
April 28, 2020 23:28
be64838 to
61cd349
Compare
April 28, 2020 23:29
Member
😃 😃 |
Sorry, something went wrong.
lysnikolaou
reviewed
Apr 29, 2020
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
This is really a great improvement! Thanks a a lot! Most of my comments are stylistic, so feel free to ignore them.
Sorry, something went wrong.
Co-Authored-By: Lysandros Nikolaou <lisandrosnik@gmail.com>
lysnikolaou
approved these changes
Apr 29, 2020
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
Yes! 🚀
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
The buildbot failures are unrelated and they are being addressed here: |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks for this one too! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Improvements in this PR:
visiting: now the code has a local variable scope with a context manager.
more explicit and carrying metadata if needed. Also helps when debugging (from experience 😉 ).
add_varthe variabletypecould actually have beenNoneas opposed to our previous declaration).https://bugs.python.org/issue40334