{{ message }}
[3.8] bpo-40431: Fix syntax typo in turtledemo (GH-19777)#19784
Merged
aeros merged 3 commits intoApr 29, 2020
Merged
Conversation
*** File "/usr/lib64/python3.9/turtledemo/__main__.py", line 275
bg="GH-d00" if clear == NORMAL else"GH-fca")
^
SyntaxError: invalid string prefix
(cherry picked from commit 49f70db)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
*** File "/usr/lib64/python3.9/turtledemo/__main__.py", line 275
bg="GH-d00" if clear == NORMAL else"GH-fca")
^
SyntaxError: invalid string prefix.
(cherry picked from commit 49f70db)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
vstinner
approved these changes
Apr 29, 2020
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
@aeros: Please replace |
Sorry, something went wrong.
Contributor
Author
I've been forgetting it less often now, but I'm still getting the hang of it. I couldn't use automerge for this PR since I had to clean up the commit message. |
Sorry, something went wrong.
Contributor
|
Thanks @aeros for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Backport for GH-19777, but it removes the Misc/NEWS entry since the typo is not a
SyntaxErrorin versions prior to 3.9.https://bugs.python.org/issue40431