◐ Shell
reader mode source ↗
Skip to content

Revert "bpo-29587: Enable implicit exception chaining with gen.throw()"#19821

Merged
vstinner merged 1 commit into
masterfrom
revert-19811-fix-issue-29587
Apr 30, 2020
Merged

Revert "bpo-29587: Enable implicit exception chaining with gen.throw()"#19821
vstinner merged 1 commit into
masterfrom
revert-19811-fix-issue-29587

Conversation

@vstinner

@vstinner vstinner commented Apr 30, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner vstinner requested a review from 1st1 as a code owner April 30, 2020 20:42
gvanrossum
gvanrossum approved these changes Apr 30, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please go ahead with the revert. I have no idea what causes the segfaults and no way to repro (all I have is a Mac).

@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member Author

@gvanrossum: I prepared this PR to repair buildbots if you are unavailable to investigate https://bugs.python.org/issue29587 bug. I'm unavailable right now and I would prefer to move back buildbot to green ASAP :-)

@vstinner vstinner merged commit 3c7f9db into master Apr 30, 2020
@vstinner vstinner deleted the revert-19811-fix-issue-29587 branch April 30, 2020 20:44
@bedevere-bot

bedevere-bot commented Apr 30, 2020

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member Author

Please go ahead with the revert.

Ok, done.

@gvanrossum

gvanrossum commented Apr 30, 2020 via email

Copy link
Copy Markdown
Member

@cjerdonek

cjerdonek commented Apr 30, 2020

Copy link
Copy Markdown
Member

Thanks, @gvanrossum and @vstinner. I can reply on the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @bedevere-bot @gvanrossum @cjerdonek @the-knights-who-say-ni