◐ Shell
reader mode source ↗
Skip to content

[WIP] bpo-40533: Make PyObject.ob_refcnt atomic in subinterpreters#19958

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:atomic_refcnt
Closed

[WIP] bpo-40533: Make PyObject.ob_refcnt atomic in subinterpreters#19958
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:atomic_refcnt

Conversation

@vstinner

@vstinner vstinner commented May 6, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

When Python is built with experimental isolated interpreters, declare
PyObject.ob_refcnt and _dictkeysobject.dk_refcnt as atomic variables.

Temporary workaround until subinterpreters stop sharing Python
objects.

https://bugs.python.org/issue40533

@vstinner
bpo-40533: Make PyObject.ob_refcnt atomic in subinterpreters …
b45420d 
When Python is built with experimental isolated interpreters, declare
PyObject.ob_refcnt and _dictkeysobject.dk_refcnt as atomic variables.

Temporary workaround until subinterpreters stop sharing Python
objects.
@vstinner vstinner requested a review from methane as a code owner May 6, 2020 15:38
@vstinner

vstinner commented May 6, 2020

Copy link
Copy Markdown
Member Author

cc @ericsnowcurrently @pablogsal @corona10

@aeros

aeros commented May 6, 2020

Copy link
Copy Markdown
Contributor

Based on the discussion at https://mail.python.org/archives/list/python-committers@python.org/thread/2WHQBHFK7UQ7OYAJV5S2QCINODVVKGJY/#2WHQBHFK7UQ7OYAJV5S2QCINODVVKGJY, I think we should leave a DO-NOT-MERGE label until the 3.9 branch is created.

@vstinner vstinner marked this pull request as draft May 6, 2020 22:34
@vstinner

vstinner commented May 6, 2020

Copy link
Copy Markdown
Member Author

Based on the discussion at https://mail.python.org/archives/list/python-committers@python.org/thread/2WHQBHFK7UQ7OYAJV5S2QCINODVVKGJY/#2WHQBHFK7UQ7OYAJV5S2QCINODVVKGJY, I think we should leave a DO-NOT-MERGE label until the 3.9 branch is created.

Right, thanks. I converted this PR into a draft to ensure that nobody merges it by mistake.

@vstinner vstinner changed the title bpo-40533: Make PyObject.ob_refcnt atomic in subinterpreters May 6, 2020
@vstinner

vstinner commented Mar 17, 2021

Copy link
Copy Markdown
Member Author

The current plan is to not share any object between two interpreters, so this PR is not needed. I close it.

@vstinner vstinner closed this Mar 17, 2021
@vstinner vstinner deleted the atomic_refcnt branch March 17, 2021 20:50
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane

1 more reviewer

@aeros aeros

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @aeros @the-knights-who-say-ni @bedevere-bot