bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio#20013
bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio#20013aeros wants to merge 5 commits into
Conversation
|
Oops, that's an easy fix for the windows failure. I should be able to just use |
Sorry, something went wrong.
Co-authored-by: pppery <mapreader@olum.org>
Oh, I hadn't realized that |
Sorry, something went wrong.
|
@vstinner Would you mind giving this a quick look-over before I merge it? This PR is fairly straightforward since it's just skipping a test, but I'm not quite comfortable yet with merging my own without an approval (particularly with the earlier CI failures). |
Sorry, something went wrong.
Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
|
Actually, are you sure that If you look at this comment of @vstinner, it seems like he might be referring to tests other than Either way, it would be important to know if this test was still hanging even with Andrew's change, as that would be a new failure variant. |
Sorry, something went wrong.
|
@cjerdonek Based on the following comment:
I'm fairly certain that |
Sorry, something went wrong.
That would be great. (In all the times I've reproduced the hang locally, Andrew's change would have prevented it.) |
Sorry, something went wrong.
|
Closing as the entire |
Sorry, something went wrong.
Note that
@unittest.skipIf()is not an option here because the child watcher is not set until aftersetUp()in the mixin.https://bugs.python.org/issue38323