{{ message }}
bpo-40503: Add compile-time configuration to PEP 615#20034
Closed
pganssle wants to merge 28 commits into
Closed
Conversation
Member
Sorry, something went wrong.
Yhg1s
reviewed
May 11, 2020
pganssle
force-pushed
the
zoneinfo_compile_config
branch
from
91cb1dd to
e3a52c6
Compare
May 12, 2020 13:46
The import machinery can be somewhat fragile, and the "seamlessly falls back to pure Python" nature of this module makes it so that a problem building the C extension or a failure to import the pure Python version might easily go unnoticed. This adds some "smoke tests" that rely on implementation details of each module to ensure that we're building the ones we think we are.
This should improve support on Windows, including actually building the C extension.
This reverts commit 874dca0.
Yhg1s
approved these changes
May 12, 2020
Yhg1s
left a comment
Yhg1s
left a comment
Member
There was a problem hiding this comment.
LG for the configure changes (for UNIX; not sure if more should be done for Windows).
Sorry, something went wrong.
Suggestion by Petr Viktorin.
pganssle
force-pushed
the
zoneinfo_compile_config
branch
from
e3a52c6 to
cb54267
Compare
May 12, 2020 16:52
zooba
reviewed
May 12, 2020
zooba
left a comment
zooba
left a comment
Member
There was a problem hiding this comment.
Windows build changes look fine, thanks for getting the installer!
Sorry, something went wrong.
This is configurable only on POSIX systems at the moment and TZPATH is initialized to an empty string on Windows.
pganssle
force-pushed
the
zoneinfo_compile_config
branch
from
cb54267 to
ddb8244
Compare
May 12, 2020 22:08
Member
Author
|
OK, I expected this to take longer than it actually did, but it looks like this is resolved, so I've gone ahead and cherry-picked the commit back into #19909. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This is the implementation for PEP 615's support for compile-time configuration of the time zone search path.
The main implementation is in #19909 — at the moment it's not merged so unfortunately the commits are also present in this PR until that one gets merged. I couldn't come up with a good way to both have a neat diff and run the CI, so I went with running the CI.
The relevant changes are the ones starting with the commit "
Add --with-tzpath to autoconf"https://bugs.python.org/issue40503