◐ Shell
reader mode source ↗
Skip to content

bpo-40645: Implement HMAC in C (GH-20129)#20129

Merged
tiran merged 1 commit into
python:masterfrom
tiran:openssl-hmac
May 17, 2020
Merged

bpo-40645: Implement HMAC in C (GH-20129)#20129
tiran merged 1 commit into
python:masterfrom
tiran:openssl-hmac

Conversation

@tiran

@tiran tiran commented May 16, 2020

Copy link
Copy Markdown
Member

The internal module _hashlib wraps and exposes OpenSSL's HMAC API. The
new code will be used in Python 3.10 after the internal implementation
details of the pure Python HMAC module are no longer part of the public API.

The code is based on a patch by Petr Viktorin for RHEL and Python 3.6.

https://bugs.python.org/issue40645

@tiran tiran force-pushed the openssl-hmac branch 4 times, most recently from 6bbb177 to 3e2345b Compare May 17, 2020 09:48
@tiran tiran requested review from encukou, gpshead and vstinner May 17, 2020 09:49
@tiran tiran marked this pull request as ready for review May 17, 2020 09:49
The internal module ``_hashlib`` wraps and exposes OpenSSL's HMAC API. The
new code will be used in Python 3.10 after the internal implementation
details of the pure Python HMAC module are no longer part of the public API.

The code is based on a patch by Petr Viktorin for RHEL and Python 3.6.
news.gmane.io
Co-Authored-By: Petr Viktorin <encukou@gmail.com>
Signed-off-by: Christian Heimes <christian@python.org>
@tiran

tiran commented May 17, 2020

Copy link
Copy Markdown
Member Author

@gpshead I'm merging the PR without your ACK to get it into Python 3.9 before beta freeze. In case you don't like it I can remove it from 3.9 and postpone the new feature to 3.10.

@tiran tiran changed the title bpo-40645: Implement HMAC in C May 17, 2020
@tiran tiran merged commit 54f2898 into python:master May 17, 2020
@tiran tiran deleted the openssl-hmac branch May 17, 2020 11:49
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
The internal module ``_hashlib`` wraps and exposes OpenSSL's HMAC API. The
new code will be used in Python 3.10 after the internal implementation
details of the pure Python HMAC module are no longer part of the public API.

The code is based on a patch by Petr Viktorin for RHEL and Python 3.6.

Co-Authored-By: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants