◐ Shell
reader mode source ↗
Skip to content

bpo-40334: Produce better error messages for non-parenthesized genexps#20153

Merged
pablogsal merged 5 commits into
python:masterfrom
lysnikolaou:nonparen-genxp
May 22, 2020
Merged

bpo-40334: Produce better error messages for non-parenthesized genexps#20153
pablogsal merged 5 commits into
python:masterfrom
lysnikolaou:nonparen-genxp

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented May 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The error message, generated for non-parenthesized generator expression
in function calls, was still the generic invalid syntax, when the
generator expression wasn't appearing as the first argument in the call.
Now, even on inputs like f(a, b, c for c in d, e), the correct error
message gets produced.

PS Last one with this bpo number. Promise!

https://bugs.python.org/issue40334

@lysnikolaou
bpo-40334: Produce better error messages for non-parenthesized genexps …
b049755 
The error message, generated for non-parenthesized generator expression
in function calls, was still the generic `invalid syntax`, when the
generator expression wasn't appearing as the first argument in the call.
Now, even on input like `f(a, b, c for c in d, e)`, the correct error
message gets produced.
@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner May 17, 2020 15:28
@lysnikolaou lysnikolaou requested a review from gvanrossum May 17, 2020 15:31
@pablogsal

pablogsal commented May 18, 2020

Copy link
Copy Markdown
Member

Humm, there are still some mistmatches. For instance:

>>> f(x=3,x for x in L,)
  File "<stdin>", line 1
    f(x=3,x for x in L,)
            ^
SyntaxError: positional argument follows keyword argument

with the old parser:

>>> f(x=3,x for x in L,)
  File "<stdin>", line 1
SyntaxError: Generator expression must be parenthesized

@lysnikolaou

lysnikolaou commented May 19, 2020

Copy link
Copy Markdown
Member Author

Humm, there are still some mistmatches. For instance:

>>> f(x=3,x for x in L,)
  File "<stdin>", line 1
    f(x=3,x for x in L,)
            ^
SyntaxError: positional argument follows keyword argument

with the old parser:

>>> f(x=3,x for x in L,)
  File "<stdin>", line 1
SyntaxError: Generator expression must be parenthesized

Fixed in ed64876.

@lysnikolaou

lysnikolaou commented May 21, 2020

Copy link
Copy Markdown
Member Author

@pablogsal Would you be able to give this another review?

@pablogsal

pablogsal commented May 21, 2020

Copy link
Copy Markdown
Member

@pablogsal Would you be able to give this another review?

Absolutely, will try to review this tonight :)

@lysnikolaou

lysnikolaou commented May 21, 2020

Copy link
Copy Markdown
Member Author

@pablogsal Would you be able to give this another review?

Absolutely, will try to review this tonight :)

No rush, whenever you find the time.

@pablogsal

pablogsal commented May 22, 2020

Copy link
Copy Markdown
Member

LGTM

I have been playing with some edge cases and it behaves as expected 🎉

@pablogsal pablogsal merged commit ae14583 into python:master May 22, 2020
@miss-islington

miss-islington commented May 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2020
@lysnikolaou @miss-islington
bpo-40334: Produce better error messages for non-parenthesized genexps ( …
9f7992d 
pythonGH-20153)

The error message, generated for a non-parenthesized generator expression
in function calls, was still the generic `invalid syntax`, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input like `f(a, b, c for c in d, e)`, the correct error message gets produced.
(cherry picked from commit ae14583)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot

bedevere-bot commented May 22, 2020

Copy link
Copy Markdown

GH-20307 is a backport of this pull request to the 3.9 branch.

@lysnikolaou lysnikolaou deleted the nonparen-genxp branch May 22, 2020 01:00
@lysnikolaou

lysnikolaou commented May 22, 2020

Copy link
Copy Markdown
Member Author

Thanks thanks!

miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington @lysnikolaou
bpo-40334: Produce better error messages for non-parenthesized genexps ( …
55c8923 
GH-20153)

The error message, generated for a non-parenthesized generator expression
in function calls, was still the generic `invalid syntax`, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input like `f(a, b, c for c in d, e)`, the correct error message gets produced.
(cherry picked from commit ae14583)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@lysnikolaou @arturoescaip
bpo-40334: Produce better error messages for non-parenthesized genexps ( …
3a887bb 
pythonGH-20153)

The error message, generated for a non-parenthesized generator expression
in function calls, was still the generic `invalid syntax`, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input like `f(a, b, c for c in d, e)`, the correct error message gets produced.
@lysnikolaou lysnikolaou mentioned this pull request May 24, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni